<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - WkWebview: calling localStorage.getItem() results in Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent."
href="https://bugs.webkit.org/show_bug.cgi?id=156651#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - WkWebview: calling localStorage.getItem() results in Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent."
href="https://bugs.webkit.org/show_bug.cgi?id=156651">bug 156651</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276579&action=diff" name="attach_276579" title="Patch">attachment 276579</a> <a href="attachment.cgi?id=276579&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276579&action=review">https://bugs.webkit.org/attachment.cgi?id=276579&action=review</a>
Please look under Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp, and add a test at the bottom of testWebKitSettings just to make sure changing the value of the setting actually works. You can just copy the test for AllowFileAccessFromFileURLs and change the name of the setting.
Anyway, this looks good to me; I presume you've tested and confirmed it solves your problem. This requires approval from another GTK+ reviewer as it adds new API, though, and from Carlos specifically as the Since tags assume a backport to 2.12.2.
<span class="quote">> Source/WebKit2/ChangeLog:7
> +</span >
You should add your commit message here, underneath the reviewed by line, then it will get added to the SVN commit message.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1268
> + _("Allow local storage access from the context of file scheme URLs"),</span >
Maybe we should say "Allow universal access" here, in case the setting is overloaded for something other than local storage in the future (or if that already is the case).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>