<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540">bug 156540</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276356 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540">bug 156540</a>
from <span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276356&action=diff" name="attach_276356" title="Patch v2">attachment 276356</a> <a href="attachment.cgi?id=276356&action=edit" title="Patch v2">[details]</a></span>
Patch v2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276356&action=review">https://bugs.webkit.org/attachment.cgi?id=276356&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.h:187
> + enum class PageBrowsingMode { BrowsingModePrivate, BrowsingModeGeneral };</span >
Please just name this
enum class PrivateBrowsing { Yes, No };
I don't think we use the term "Browsing Mode" anywhere else.
<span class="quote">> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:228
> + auto& hostsToPluginIdentifierData = browsingMode == PageBrowsingMode::BrowsingModePrivate ? m_hostsToPluginIdentifierDataInPrivateBrowsing : m_hostsToPluginIdentifierData;</span >
Extra spice here.
<span class="quote">> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:236
> - if (policiesByIdentifier.contains(bundleIdentifierToSet))
> - versionsToPolicies = policiesByIdentifier.get(bundleIdentifierToSet);
> + auto versionsToPoliciesIterator = policiesByIdentifier.find(bundleIdentifierToSet);
> + if (versionsToPoliciesIterator != policiesByIdentifier.end())
> + versionsToPolicies = versionsToPoliciesIterator->value;</span >
I don't think this change is needed - it's not avoiding a hash lookup and it makes things harder to read.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>