<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540">bug 156540</a>
from <span class="vcard"><a class="email" href="mailto:iting_liu@apple.com" title="iting_liu@apple.com">iting_liu@apple.com</a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276356&action=diff" name="attach_276356" title="Patch v2">attachment 276356</a> <a href="attachment.cgi?id=276356&action=edit" title="Patch v2">[details]</a></span>
Patch v2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276356&action=review">https://bugs.webkit.org/attachment.cgi?id=276356&action=review</a>
<span class="quote">>> Source/WebKit2/UIProcess/WebProcessPool.h:187
>> + enum class PageBrowsingMode { BrowsingModePrivate, BrowsingModeGeneral };
>
> Please just name this
>
> enum class PrivateBrowsing { Yes, No };
>
> I don't think we use the term "Browsing Mode" anywhere else.</span >
Sure.
<span class="quote">>> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:228
>> + auto& hostsToPluginIdentifierData = browsingMode == PageBrowsingMode::BrowsingModePrivate ? m_hostsToPluginIdentifierDataInPrivateBrowsing : m_hostsToPluginIdentifierData;
>
> Extra spice here.</span >
Oops. Removed.
<span class="quote">>> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:236
>> + versionsToPolicies = versionsToPoliciesIterator->value;
>
> I don't think this change is needed - it's not avoiding a hash lookup and it makes things harder to read.</span >
Anders clairified that we don't need to use .contains beforehand; it'll just return a constructed object if it's not in there. I'll revert back to the original and get rid of .contains().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>