<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - In Voice over, activating a fragment URL should transfer focus and caret to the destination"
href="https://bugs.webkit.org/show_bug.cgi?id=116046#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - In Voice over, activating a fragment URL should transfer focus and caret to the destination"
href="https://bugs.webkit.org/show_bug.cgi?id=116046">bug 116046</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=116046#c20">comment #20</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=275781&action=diff" name="attach_275781" title="patch">attachment 275781</a> <a href="attachment.cgi?id=275781&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=275781&action=review">https://bugs.webkit.org/attachment.cgi?id=275781&action=review</a>
>
> >> Source/WebCore/dom/Document.cpp:693
> >> + m_focusNavigationStartingPoint = nullptr;
> >
> > I'd call this focusNavigationStartingNode instead since "point" usually refers to either a graphical coordinate
> > or a single point in DOM tree (e.g. Position / VisiblePosition).
>
> On my second look, this is really
> <a href="https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus">https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus</a>-
> navigation-starting-point
> so we should call it exactly that: sequentialFocusNavigationStartingPoint
> with that URL in a comment.
>
> >>> Source/WebCore/dom/Document.h:1479
> >>> + RefPtr<Range> m_focusNavigationStartingPoint;
> >>
> >> Why are we using Range for this?
> >
> > I'm using Range so that we can tell if the node has been removed from document tree and easily pick the next node. Is there a way to tell if a node has been removed or is no longer valid?
>
> Is that really necessary? Where in the HTML spec does it say that we need
> to use the next node in such a case?</span >
I'm following this spec <a href="https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation-starting-point">https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation-starting-point</a>
I think it's reasonable to have some fallback node in case the starting node is removed. We don't want to jump to the top of document, right?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>