<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156147#c24">comment #24</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=156147#c23">comment #23</a>)
> > (In reply to <a href="show_bug.cgi?id=156147#c19">comment #19</a>)
> > > Created <span class=""><a href="attachment.cgi?id=275529&action=diff" name="attach_275529" title="Patch">attachment 275529</a> <a href="attachment.cgi?id=275529&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > don't tokenize async/await as keywords, hopefully not costing too much perf
> >
> > Can you test parser performance on this? Specifically, octane's
> > jquery/closure benchmarks.
> >
> > I'm working on making our parser faster as we've
> > regressed 10% since we've implemented arrow functions
> > and I don't want to introduce anything that slows the
> > parser down.
>
> It was regressing CodeLoad by quite a lot. I've managed to get it down to
> about a ~5% regression on average with some improvements for arrow function
> and method parsing, and can probably squeeze a few more out of it in other
> ways.</span >
Based on this information I think it's worth having a compile
time flag instead of a runtime flag. That way async functions
are disabled we don't slow down the parser. Unless the runtime
flag doesn't slow down the parser with async functions disabled.
That said, I think it's worth getting the performance regression as down
as possible because we will presumably remove the runtime/compile time flag
at some point.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>