<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r198792): [GTK] Inspector crashes in Inspector::Protocol::getEnumConstantValue since r198792"
href="https://bugs.webkit.org/show_bug.cgi?id=155745">bug 155745</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275268 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r198792): [GTK] Inspector crashes in Inspector::Protocol::getEnumConstantValue since r198792"
href="https://bugs.webkit.org/show_bug.cgi?id=155745#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r198792): [GTK] Inspector crashes in Inspector::Protocol::getEnumConstantValue since r198792"
href="https://bugs.webkit.org/show_bug.cgi?id=155745">bug 155745</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275268&action=diff" name="attach_275268" title="Rebased patch to fix the build">attachment 275268</a> <a href="attachment.cgi?id=275268&action=edit" title="Rebased patch to fix the build">[details]</a></span>
Rebased patch to fix the build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275268&action=review">https://bugs.webkit.org/attachment.cgi?id=275268&action=review</a>
r=me
Just some style issues remain. Please post an updated patch so we can set cq+ on it.
<span class="quote">> Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:173
> + return ['\n\n'.join(lines)]</span >
The pattern used in these generators is that lines are joined by one newline, and sections are joined by two newlines. So you could just return the array here and the caller will join it the same way.
<span class="quote">> Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:412
> + sections.insert(0, '\n'.join([</span >
Why do we need to use insert here? The generator's sections should be in the same order as the generated sections.
<span class="quote">> Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:154
> + sections.insert(0, 'namespace %s {' % self.helpers_namespace())</span >
Instead of using insert and causing the generator and generated file to have different line order, please use a guard at the top like 'if not self.assigned_enum_values()' and return [] before generating sections.
<span class="quote">> Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:156
> + return ['\n\n'.join(sections)]</span >
See above comment, should not be necessary to join sections here if the caller can extend with this method's result.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>