<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361">bug 153361</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275266 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361#c51">Comment # 51</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361">bug 153361</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275266&action=diff" name="attach_275266" title="Patch">attachment 275266</a> <a href="attachment.cgi?id=275266&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275266&action=review">https://bugs.webkit.org/attachment.cgi?id=275266&action=review</a>
r=me with comments.
<span class="quote">> Source/WebCore/editing/CompositeEditCommand.cpp:88
> +void AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyIndexesWithEditCommandEndingSelection(const VisibleSelection& selection)</span >
This is an overly long function name. We don't normally use "configure" prefix these things.
I think something along the line of setTextDeletedByUnapplyRangeFromEndingSelection will suffice.
<span class="quote">> Source/WebCore/editing/CompositeEditCommand.cpp:98
> +void AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyStartIndexWithEditCommandStartingSelection(const VisibleSelection& selection)</span >
Ditto about the function name.
<span class="quote">> Source/WebCore/editing/CompositeEditCommand.cpp:752
> +static EditAction deleteSelectionEditingActionForEditingAction(EditAction editingAction)</span >
This function name doesn't tell us what kind of conversion we're doing.
This might be a rare case in which inlining the code below as in:
editingAction() == EditActionCut ? EditActionCut : EditActionDelete
might be more clear.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>