<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Autoscrolling from a drag selection does not work in full screen, or when the window is against the screen edge"
href="https://bugs.webkit.org/show_bug.cgi?id=155858">bug 155858</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Autoscrolling from a drag selection does not work in full screen, or when the window is against the screen edge"
href="https://bugs.webkit.org/show_bug.cgi?id=155858#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Autoscrolling from a drag selection does not work in full screen, or when the window is against the screen edge"
href="https://bugs.webkit.org/show_bug.cgi?id=155858">bug 155858</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>Thanks Simon!
(In reply to <a href="show_bug.cgi?id=155858#c10">comment #10</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=274942&action=diff" name="attach_274942" title="Patch">attachment 274942</a> <a href="attachment.cgi?id=274942&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=274942&action=review">https://bugs.webkit.org/attachment.cgi?id=274942&action=review</a>
>
> > Source/WebCore/page/mac/EventHandlerMac.mm:1125
> > + float insetScreenLeftEdge = screenLeftEdge + EDGE_DISTANCE_THRESHOLD;
> > + float screenRightEdge = screenRect.maxX();
> > + float insetScreenRightEdge = screenRightEdge - EDGE_DISTANCE_THRESHOLD;
>
> You could inset the rect to get insetScreenLeftEdge, insetScreenRightEdge
> which is slightly cleaner.
> </span >
Somehow I missed this comment before I committed, but also this strikes me as a slightly more confusing way to do things. (Though maybe I am not thinking of exactly the same rect insetting code that you are?)
<span class="quote">> > Source/WebCore/platform/PlatformScreen.h:68
> > + NSScreen *screenForDisplayID(PlatformDisplayID displayID);
>
> No need for displayID name.</span >
Removed.
<a href="http://trac.webkit.org/changeset/198692">http://trac.webkit.org/changeset/198692</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>