<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Provide NSSpellChecker spellChecking methods with the current insertion point"
href="https://bugs.webkit.org/show_bug.cgi?id=155532#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Provide NSSpellChecker spellChecking methods with the current insertion point"
href="https://bugs.webkit.org/show_bug.cgi?id=155532">bug 155532</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155532#c13">comment #13</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=155532#c12">comment #12</a>)
> > (In reply to <a href="show_bug.cgi?id=155532#c10">comment #10</a>)
> > > That being said, I do not have a great understanding of any architectural
> > > decisions guiding these WebCore classes. So if you think it's a
> > > better/cleaner architecture here to stick to the offset, then I would be
> > > happy to do that. Do you think that's better even if I add some additional
> > > parameters in the future?
> >
> > This is really a layering question.
> >
> > Before this change, these functions were an abstract interface to spell
> > checking that was independent of the DOM. After the change, they are hooks
> > for spell checking that are not independent of the DOM.
> >
> > I don’t have a strong feeling about which design is better, but I don’t like
> > place we have landed with the division of responsibilities where extracting
> > the text to spell check is a job for the caller, but interpreting the
> > selection position is a job for the spell checking functions. I’d prefer
> > that the work of extracting the text to spell check and the other contextual
> > information needed to correctly check from the DOM was either done entirely
> > by the caller or entirely by the spell checking functions.
> >
> > This is not an urgent issue but nice to resolve in the longer term. We can
> > talk in person about this at some point.
>
> Sounds good! I'm happy to get this in a better place. Thanks for your input!</span >
I posted a patch to address this: <a class="bz_bug_link
bz_status_NEW "
title="NEW - Spell checking should not use DOM types"
href="show_bug.cgi?id=155908">https://bugs.webkit.org/show_bug.cgi?id=155908</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>