<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795">bug 155795</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #274904 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795">bug 155795</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274904&action=diff" name="attach_274904" title="Patch">attachment 274904</a> <a href="attachment.cgi?id=274904&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274904&action=review">https://bugs.webkit.org/attachment.cgi?id=274904&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/StringPrototype.cpp:801
> + if (!ropeBuilder.append(string))
> + return throwOutOfMemoryError(&exec), nullptr;</span >
We should use a more conventional two line body here:
if (!ropeBuilder.append(string)) {
throwOutOfMemoryError(&exec);
return nullptr;
}
<span class="quote">> Source/JavaScriptCore/runtime/StringPrototype.cpp:806
> + if (!substr || !ropeBuilder.append(substr))
> + return throwOutOfMemoryError(&exec), nullptr;</span >
Ditto.
<span class="quote">> Source/JavaScriptCore/runtime/StringPrototype.cpp:861
> +enum class StringPaddingLocation {
> + Start,
> + End
> +};</span >
I think this reads better on a single line.
<span class="quote">> Source/JavaScriptCore/runtime/StringPrototype.cpp:903
> + UChar character = filler ? filler->view(&exec)[0] : ' ';</span >
This should use the unsafeView function for better efficiency rather than the view function.
<span class="quote">> Source/JavaScriptCore/runtime/StringPrototype.cpp:909
> + filler = repeatStringPattern(exec, fillLength, filler, ropeBuilder);</span >
I think you misunderstood my suggestion. I suggested passing the ropeBuilder in and create a function that would append to it, not so a function that will use it and then call "release". The point of the optimization is to not do a second release.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>