<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Ninja build path is incorrect when git branch name is appended to WebKitBuild"
href="https://bugs.webkit.org/show_bug.cgi?id=155796#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Ninja build path is incorrect when git branch name is appended to WebKitBuild"
href="https://bugs.webkit.org/show_bug.cgi?id=155796">bug 155796</a>
from <span class="vcard"><a class="email" href="mailto:mbbill@gmail.com" title="Bill Ming <mbbill@gmail.com>"> <span class="fn">Bill Ming</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155796#c3">comment #3</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=274753&action=diff" name="attach_274753" title="Patch">attachment 274753</a> <a href="attachment.cgi?id=274753&action=edit" title="Patch">[details]</a></span>
> Patch
>
> I'm glad to hear from people building with different configurations!
>
> Would it work to use determineBaseProductDir(); and chdir $baseProductDir ?
> That would probably be cleaner, so we don't have to add the same git checks
> in two different places.</span >
Thanks for the review. The patch is updated.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>