<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fixed compilation with GCC 4.8."
href="https://bugs.webkit.org/show_bug.cgi?id=155698">bug 155698</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #274541 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fixed compilation with GCC 4.8."
href="https://bugs.webkit.org/show_bug.cgi?id=155698#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fixed compilation with GCC 4.8."
href="https://bugs.webkit.org/show_bug.cgi?id=155698">bug 155698</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274541&action=diff" name="attach_274541" title="Patch">attachment 274541</a> <a href="attachment.cgi?id=274541&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274541&action=review">https://bugs.webkit.org/attachment.cgi?id=274541&action=review</a>
<span class="quote">> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59
> + ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash)
> + : key(_key), value(_value), hash(_hash)</span >
There is no need to add leading underscores here. The following is valid C++ that implements the same behavior:
ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash)
: key(key), value(value), hash(hash)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>