<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] correctly handle indexed properties in Object.getOwnPropertyDescriptors"
href="https://bugs.webkit.org/show_bug.cgi?id=155563#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] correctly handle indexed properties in Object.getOwnPropertyDescriptors"
href="https://bugs.webkit.org/show_bug.cgi?id=155563">bug 155563</a>
from <span class="vcard"><a class="email" href="mailto:caitp@igalia.com" title="Caitlin Potter (:caitp) <caitp@igalia.com>"> <span class="fn">Caitlin Potter (:caitp)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274287&action=diff" name="attach_274287" title="Patch">attachment 274287</a> <a href="attachment.cgi?id=274287&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274287&action=review">https://bugs.webkit.org/attachment.cgi?id=274287&action=review</a>
<span class="quote">>> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:253
>> + JSObject::put(descriptors, exec, propertyName, fromDescriptor, slot);
>
> You need an exception check here.
> An exception check is also needed above
> after constructEmptyObject(). I suggest
> caching the VM in a local variable and checking
> VM.exception()</span >
per spec, this should not cause an observable error (spec algorithm uses CreateDataProperty), which ignores accessors on the prototype. Is there a model for this behaviour in JSC that permits indexed properties?
<span class="quote">>> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors-proxy.js:17
>> }
>
> Can we also add a test where the lack of an exception
> check above is observable? I think it's probably doable
> by having a setter/getter on Object.prototype that both
> throw.</span >
as noted above, that shiuld be ignored, but ill add a test to verify that. Good catch</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>