<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864">bug 153864</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274093&action=diff" name="attach_274093" title="Patch">attachment 274093</a> <a href="attachment.cgi?id=274093&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274093&action=review">https://bugs.webkit.org/attachment.cgi?id=274093&action=review</a>
<span class="quote">>> Source/JavaScriptCore/ChangeLog:3
>> + Invoking super()/super inside of the eval should not lead to SyntaxError
>
> Do we have a bug open for new.target inside eval?</span >
Yes, I did this recently
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Class syntax. Access to new.target inside of the eval should not lead to SyntaxError"
href="show_bug.cgi?id=155545">https://bugs.webkit.org/show_bug.cgi?id=155545</a>
<span class="quote">>>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:643
>>> + if (needsToUpdateArrowFunctionContext() && !codeBlock->isArrowFunctionContext() && !isDerivedConstructorContext()) {
>>
>> Why the "!isDerivedConstructorContext()" check?
>
> Ah, I guess it's that way so we don't recreate a scope. I think I understand.</span >
Yes, that is correct. It is for this case:
class C {};
class D extends C {
constructor() {
eval("(()=>super())()");//Error
}
}
new D();
Otherwise we will have two context scope for 'this'. I've spend last three evenings to find out why mention simple test case did not work
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4145
>> + return m_scopeNode->doAnyInnerArrowFunctionsUseNewTarget() || m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();
>
> I believe m_codeBlock->usesEval() should always be true if m_scopeNode->doAnyInnerAroowFunctionsUseEval().
> You should double check though.</span >
It is true, but unfortunately this patch cover cases when we do not have arrow function, for instance from previous comments, so I need to check m_codeBlock->usesEval(). Possible we need to change name of the function isNewTargetUsedInInnerArrowFunction -> isNewTargetUsedInInnerArrowFunctionOrEval
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4150
>> + return m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseSuperProperty() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();
>
> ditto</span >
The same
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4155
>> + return m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();
>
> ditto</span >
The same
<span class="quote">>> Source/JavaScriptCore/parser/Parser.cpp:3848
>> + // TODO: Change error message for more suitable. <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Update syntax error text 'super is only valid inside functions' to more suitable"
href="show_bug.cgi?id=155491">https://bugs.webkit.org/show_bug.cgi?id=155491</a>
>
> Style: FIXME not TODO</span >
Will be updated in next patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>