<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864">bug 153864</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153864#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=274093&action=diff" name="attach_274093" title="Patch">attachment 274093</a> <a href="attachment.cgi?id=274093&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=274093&action=review">https://bugs.webkit.org/attachment.cgi?id=274093&action=review</a>
>
> >> Source/JavaScriptCore/ChangeLog:3
> >> + Invoking super()/super inside of the eval should not lead to SyntaxError
> >
> > Do we have a bug open for new.target inside eval?
>
> Yes, I did this recently
> <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Class syntax. Access to new.target inside of the eval should not lead to SyntaxError"
href="show_bug.cgi?id=155545">https://bugs.webkit.org/show_bug.cgi?id=155545</a>
>
> >>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:643
> >>> + if (needsToUpdateArrowFunctionContext() && !codeBlock->isArrowFunctionContext() && !isDerivedConstructorContext()) {
> >>
> >> Why the "!isDerivedConstructorContext()" check?
> >
> > Ah, I guess it's that way so we don't recreate a scope. I think I understand.
>
> Yes, that is correct. It is for this case:
> class C {};
> class D extends C {
> constructor() {
> eval("(()=>super())()");//Error
> }
> }
> new D();
> Otherwise we will have two context scope for 'this'. I've spend last three
> evenings to find out why mention simple test case did not work
>
> >> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4145
> >> + return m_scopeNode->doAnyInnerArrowFunctionsUseNewTarget() || m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();
> >
> > I believe m_codeBlock->usesEval() should always be true if m_scopeNode->doAnyInnerAroowFunctionsUseEval().
> > You should double check though.
>
> It is true, but unfortunately this patch cover cases when we do not have
> arrow function, for instance from previous comments, so I need to check
> m_codeBlock->usesEval(). Possible we need to change name of the function
> isNewTargetUsedInInnerArrowFunction ->
> isNewTargetUsedInInnerArrowFunctionOrEval</span >
What I mean is shouldn't it be sufficient to just check m_codeBlock->usesEval()?
It should never be the case that m_scopeNode->innerArrowEval() is true but m_codeBlock->usesEval() is false.
Therefore, m_codeBlock->usesEval() should cover everything.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>