<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Invoking super()/super inside of the eval should not lead to SyntaxError"
href="https://bugs.webkit.org/show_bug.cgi?id=153864">bug 153864</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274093&action=diff" name="attach_274093" title="Patch">attachment 274093</a> <a href="attachment.cgi?id=274093&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274093&action=review">https://bugs.webkit.org/attachment.cgi?id=274093&action=review</a>
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:643
> + if (needsToUpdateArrowFunctionContext() && !codeBlock->isArrowFunctionContext() && !isDerivedConstructorContext()) {</span >
Why the "!isDerivedConstructorContext()" check?
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4145
> + return m_scopeNode->doAnyInnerArrowFunctionsUseNewTarget() || m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();</span >
I believe m_codeBlock->usesEval() should always be true if m_scopeNode->doAnyInnerAroowFunctionsUseEval().
You should double check though.
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4150
> + return m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseSuperProperty() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();</span >
ditto
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4155
> + return m_scopeNode->doAnyInnerArrowFunctionsUseSuperCall() || m_scopeNode->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();</span >
ditto
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:3848
> + // TODO: Change error message for more suitable. <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Update syntax error text 'super is only valid inside functions' to more suitable"
href="show_bug.cgi?id=155491">https://bugs.webkit.org/show_bug.cgi?id=155491</a> </span >
Style: FIXME not TODO</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>