<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add Automation.evaluateJavaScriptFunction"
href="https://bugs.webkit.org/show_bug.cgi?id=155524#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add Automation.evaluateJavaScriptFunction"
href="https://bugs.webkit.org/show_bug.cgi?id=155524">bug 155524</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274158&action=diff" name="attach_274158" title="WIP">attachment 274158</a> <a href="attachment.cgi?id=274158&action=edit" title="WIP">[details]</a></span>
WIP
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274158&action=review">https://bugs.webkit.org/attachment.cgi?id=274158&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:43
> +static JSObjectRef toJSArray(JSContextRef context, const Vector<T>& data, JSValueRef (*converter)(JSContextRef, const T&), JSValueRef* exception = 0)</span >
Only nit I have is this 0 could be nullptr.
<span class="quote">> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:48
> + return JSObjectMakeArray(context, 0, 0, exception);</span >
Second 0 here could be nullptr.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>