<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] WKPreviewAction conforms to NSCopying but doesn’t override -copyWithZone:"
href="https://bugs.webkit.org/show_bug.cgi?id=155395#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] WKPreviewAction conforms to NSCopying but doesn’t override -copyWithZone:"
href="https://bugs.webkit.org/show_bug.cgi?id=155395">bug 155395</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155395#c9">comment #9</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=274024&action=diff" name="attach_274024" title="Patch">attachment 274024</a> <a href="attachment.cgi?id=274024&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=274024&action=review">https://bugs.webkit.org/attachment.cgi?id=274024&action=review</a>
>
> You should remove the explicit conformance to NSCopying of WKPreviewAction
> since UIPreviewAction already conforms to it.
>
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreviewActionItem.mm:45
> > + WKPreviewAction *action = [super copyWithZone:zone];
> > + action->_identifier = self.identifier;
> > + return action;
>
> Since WKPreviewAction is immutable, this can be implemented as:
>
> return [self retain];</span >
Actually, it looks like it isn't completely immutable, so you should do your thing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>