<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Leak: Accelerated ImageBufferCairo doesn't destroy the used textures"
href="https://bugs.webkit.org/show_bug.cgi?id=155431#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Leak: Accelerated ImageBufferCairo doesn't destroy the used textures"
href="https://bugs.webkit.org/show_bug.cgi?id=155431">bug 155431</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273958&action=diff" name="attach_273958" title="Patch">attachment 273958</a> <a href="attachment.cgi?id=273958&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273958&action=review">https://bugs.webkit.org/attachment.cgi?id=273958&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:88
> + if (!m_texture)
> + return;</span >
I assume m_texture has to be present for m_compositorTexture to be created, but it would be better not to count on that, and just either delete m_texture or m_compositorTexture if they are non-null.
<span class="quote">> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:90
> + GLContext::sharingContext()->makeContextCurrent();</span >
This destructor should store the previous context and restore it when done, as we usually do.
At some point, we should also use a separate offscreen context for the accelerated canvas, and not the sharing context.
<span class="quote">> Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h:58
> + ~ImageBufferData();</span >
This should be virtual.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>