<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255">bug 155255</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273748 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255">bug 155255</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273748&action=diff" name="attach_273748" title="Patch">attachment 273748</a> <a href="attachment.cgi?id=273748&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273748&action=review">https://bugs.webkit.org/attachment.cgi?id=273748&action=review</a>
cq- for now while we discuss whether it's worth it supporting this or not.
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:143
> + if (ReliefLogger::loggingEnabled())
> + LOG(MemoryPressure, "Polled memory pressure (%s)", isUnderMemoryPressure ? "critical" : "non-critical");
> +
> + MemoryPressureHandler::singleton().setUnderMemoryPressure(isUnderMemoryPressure);
> + callOnMainThread([isUnderMemoryPressure] {
> + MemoryPressureHandler::singleton().respondToMemoryPressure(isUnderMemoryPressure ? Critical::Yes : Critical::No);
> + });</span >
This is mostly duplicated code, we could probably move it to a function that receives the isUnderMemoryPressure value.
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:149
> + sleep(s_pollingIntervalInSeconds);
> + } while (true);</span >
I'm not happy with this either, but I have no idea how to do this if meminfo is not pollable. Note that there's one memory pressure handler per process . . .</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>