<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - eventMayStartDrag() does not check for shiftKey or isOverLink"
href="https://bugs.webkit.org/show_bug.cgi?id=155390">155390</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>eventMayStartDrag() does not check for shiftKey or isOverLink
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Event Handling
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>tonikitoo@webkit.org
</td>
</tr></table>
<p>
<div>
<pre>This is a follow up of Darin's comment in <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Selecting with shift+drag results in unexpected drag-n-drop"
href="show_bug.cgi?id=155314#c9">https://bugs.webkit.org/show_bug.cgi?id=155314#c9</a>.
Basically in <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Selecting with shift+drag results in unexpected drag-n-drop"
href="show_bug.cgi?id=155314">bug 155314</a>, in order to make shift+click not trigger drag-n-drop when extending an existing selection, we changed the way m_mouseDownMayStartDrag is set on EventHandler::handleMousePressEvent, as shown below:
- m_mouseDownMayStartDrag = singleClick;
+ m_mouseDownMayStartDrag = singleClick && (!event.event().shiftKey() || event.isOverLink());
Although makes a desired change in WebKit's editing behavior (as per [1] and [2]), it makes this setter code get out of sync with eventMayStartDrag.
Bug is about investigating the implications, and sync both pieces up again.
[1] <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Selecting with shift+drag results in unexpected drag-n-drop"
href="show_bug.cgi?id=155314#c4">https://bugs.webkit.org/show_bug.cgi?id=155314#c4</a>
[2] <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Selecting with shift+drag results in unexpected drag-n-drop"
href="show_bug.cgi?id=155314#c8">https://bugs.webkit.org/show_bug.cgi?id=155314#c8</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>