<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255">bug 155255</a>
from <span class="vcard"><a class="email" href="mailto:eocanha@igalia.com" title="Enrique Ocaña <eocanha@igalia.com>"> <span class="fn">Enrique Ocaña</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155255#c6">comment #6</a>)
<span class="quote">> Looks good to me, but I think it makes sense to have someone more closely
> involved with the port sign off an polling proc every second.</span >
Ok.
<span class="quote">> > Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:56
> > +static const size_t s_memoryCriticalLimit = 100 * KB * KB; // 100 MB
> > +static const size_t s_memoryNonCriticalLimit = 300 * KB * KB; // 300 MB
> It might be worth discussing a bit where these numbers come from. A comment
> here or a note in the ChangeLog or bug is fine.</span >
Those numbers are arbitrary. I found them right for our downstream port, where we're interested in minimizing the RAM usage.
<span class="quote">> > Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:227
> > if (ReliefLogger::loggingEnabled() && isUnderMemoryPressure())
> > LOG(MemoryPressure, "System is no longer under memory pressure.");
>
> This is quite strange. If isUnderMemoryPressure returns true, a message is
> printed that the system is not under memory pressure. Do you have understand
> why this is?</span >
Hmmm... actually not. Changseok should know.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>