<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement bounds/position and index related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=154976">bug 154976</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=272834&action=diff" name="attach_272834" title="patch">attachment 272834</a> <a href="attachment.cgi?id=272834&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=272834&action=review">https://bugs.webkit.org/attachment.cgi?id=272834&action=review</a>
<span class="quote">>> Source/WebCore/ChangeLog:9
>> + VoiceOver navigation issue.
>
> issues.
>
> what are those issues?</span >
Like word boundary for multilanguage, left/right word should consider the space at node boundary, nextCharacterOffset should match VisiblePosition behavior. These are all covered in modified tests.
<span class="quote">>> Source/WebCore/accessibility/AXObjectCache.cpp:2329
>> + InlineBox* inlineBox;
>
> initialize to nullptr just in case the getInlineBox doesn't do it</span >
Ok.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1967
>> + LayoutRect ourrect = rect1;
>
> ourRect</span >
Ok
<span class="quote">>> LayoutTests/ChangeLog:8
>> + * accessibility/mac/text-marker-for-index-expected.txt: Added.
>
> do you have test for textMarkerForPosition, line navigation and text marker bounds?</span >
Position and bounds are covered by existing tests. Line navigation has not been implemented yet.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>