<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Enable -Wnon-virtual-dtor"
href="https://bugs.webkit.org/show_bug.cgi?id=155048#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Enable -Wnon-virtual-dtor"
href="https://bugs.webkit.org/show_bug.cgi?id=155048">bug 155048</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>For the record:
-Wdelete-non-virtual-dtor (C++ and Objective-C++ only)
Warn when "delete" is used to destroy an instance of a class that
has virtual functions and non-virtual destructor. It is unsafe to
delete an instance of a derived class through a pointer to a base
class if the base class does not have a virtual destructor. This
warning is enabled by -Wall.
-Wnon-virtual-dtor (C++ and Objective-C++ only)
Warn when a class has virtual functions and an accessible non-
virtual destructor itself or in an accessible polymorphic base
class, in which case it is possible but unsafe to delete an
instance of a derived class through a pointer to the class itself
or base class. This warning is automatically enabled if -Weffc++
is specified.
Note that we currently use -Wall, but not spammy and nonstandard -Weffc++ (if you haven't heard of -Weffc++, it enables warnings about things Scott Meyers tells us not to do :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>