<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period or colon character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056">bug 149056</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #272757 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period or colon character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period or colon character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056">bug 149056</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=272757&action=diff" name="attach_272757" title="Expand newAdjacentwords selection from its boundaries">attachment 272757</a> <a href="attachment.cgi?id=272757&action=edit" title="Expand newAdjacentwords selection from its boundaries">[details]</a></span>
Expand newAdjacentwords selection from its boundaries
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=272757&action=review">https://bugs.webkit.org/attachment.cgi?id=272757&action=review</a>
A bug fix like this needs a regression test to help make clear exactly what it changes and fixes. Any reason we don’t have one here?
<span class="quote">> Source/WebCore/ChangeLog:3
> + [GTK] Spellchecker rejects word when adding a period or colon character if there is no trailing space before the next word</span >
This is not a GTK-specific patch and should not have the GTK prefix on it.
<span class="quote">> Source/WebCore/editing/Editor.cpp:3407
> + // being conservative allow to fix that and doesn't seem to disturb any other behavior.</span >
"allow to fix that" is not the right phrase here
"fixes that" would be correct grammar
<span class="quote">> Source/WebCore/editing/VisibleSelection.h:88
> + int getLength() const { return end().computeOffsetInContainerNode() - start().computeOffsetInContainerNode(); }</span >
This naming is not consistent with WebKit coding style. We don’t use get in the name of functions like this.
This code is wrong. It will give an incorrect value any time the start and end positions are not in the same container node, or when they are in the same container node, but it is not a text node.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>