<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool."
href="https://bugs.webkit.org/show_bug.cgi?id=154628#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool."
href="https://bugs.webkit.org/show_bug.cgi?id=154628">bug 154628</a>
from <span class="vcard"><a class="email" href="mailto:zalan@apple.com" title="zalan <zalan@apple.com>"> <span class="fn">zalan</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154628#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=272083&action=diff" name="attach_272083" title="Patch">attachment 272083</a> <a href="attachment.cgi?id=272083&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=272083&action=review">https://bugs.webkit.org/attachment.cgi?id=272083&action=review</a>
>
> > Source/WebCore/rendering/RenderBlock.h:125
> > + LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const
>
> I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent?
> IndentionRequired?</span >
I dislike it very much too, but i'd rather have it in a follow-up patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>