<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - NetworkCache: Web process leaks resource buffer when using shareable reasources"
href="https://bugs.webkit.org/show_bug.cgi?id=154852">bug 154852</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>ap@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - NetworkCache: Web process leaks resource buffer when using shareable reasources"
href="https://bugs.webkit.org/show_bug.cgi?id=154852#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - NetworkCache: Web process leaks resource buffer when using shareable reasources"
href="https://bugs.webkit.org/show_bug.cgi?id=154852">bug 154852</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>I can see how this avoids refcount churn, however I don't see how this can fix a leak. What am I missing?
+ ResourceLoader::didReceiveBuffer() expects a PassRefPtr, but we
+ are passing a raw pointer making PassRefPtr to take another
+ reference instead of transfering the ownership as expected.
This was compensated by the original RefPtr still having a pointer to the object, so there was also one more deref().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>