<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent()"
href="https://bugs.webkit.org/show_bug.cgi?id=153829">bug 153829</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #272481 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent()"
href="https://bugs.webkit.org/show_bug.cgi?id=153829#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent()"
href="https://bugs.webkit.org/show_bug.cgi?id=153829">bug 153829</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=272481&action=diff" name="attach_272481" title="Remove gesture sequence from touch sequence set">attachment 272481</a> <a href="attachment.cgi?id=272481&action=edit" title="Remove gesture sequence from touch sequence set">[details]</a></span>
Remove gesture sequence from touch sequence set
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=272481&action=review">https://bugs.webkit.org/attachment.cgi?id=272481&action=review</a>
You should remove the tests the pass now from the TestExpectations file.
<span class="quote">> Source/WebKit2/ChangeLog:9
> + Once a touch event sequence is identified as a gesture, remove it
> + from the list of handled touch events.
> +
> + Reviewed by NOBODY (OOPS!).</span >
We normally add the description after the Reviewed by line.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:962
> + if (priv->touchEvents.contains(sequence))
> + priv->touchEvents.remove(sequence);</span >
No need to check the sequence is in the map, remove() does nothing if not present.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>