<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - [GTK] webkitWebViewBaseRealize broken in Wayland with USE_OPENGL=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=154814">bug 154814</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>INVALID
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - [GTK] webkitWebViewBaseRealize broken in Wayland with USE_OPENGL=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=154814#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - [GTK] webkitWebViewBaseRealize broken in Wayland with USE_OPENGL=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=154814">bug 154814</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154814#c3">comment #3</a>)
<span class="quote">> It's not so simple, another problem is that in
> WebCore::PlatformDisplay::createPlatformDisplay,
> gdk_display_manager_get_default_display returns some non-null display for
> which neither GDK_IS_X11_DISPLAY nor GDK_IS_WAYLAND_DISPLAY is true</span >
Well I couldn't explain that, so I thought about it a bit more, and actually it is returning a GdkDisplayWayland. The problem is that our Wayland support depends on OpenGL, and we have it baked into our build system to enforce this. I can see in our build logs:
-- Disabling ENABLE_3D_TRANSFORMS since ENABLE_OPENGL is disabled.
-- Disabling ENABLE_WAYLAND_TARGET since ENABLE_OPENGL is disabled.
-- Disabling ENABLE_WEBGL since ENABLE_OPENGL is disabled.
-- Disabling USE_REDIRECTED_XCOMPOSITE_WINDOW since ENABLE_OPENGL is disabled.
-- Enabled features:
-- ENABLE_ACCELERATED_2D_CANVAS ............ OFF
-- ENABLE_CREDENTIAL_STORAGE ON
-- ENABLE_DRAG_SUPPORT ..................... ON
-- ENABLE_GEOLOCATION ON
-- ENABLE_GLES2 ............................ OFF
-- ENABLE_GTKDOC ON
-- ENABLE_ICONDATABASE ..................... ON
-- ENABLE_INTROSPECTION ON
-- ENABLE_JIT .............................. ON
-- ENABLE_MEMORY_SAMPLER ON
-- ENABLE_MINIBROWSER ...................... ON
-- ENABLE_OPENGL OFF
-- ENABLE_PLUGIN_PROCESS_GTK2 .............. ON
-- ENABLE_QUARTZ_TARGET OFF
-- ENABLE_SAMPLING_PROFILER ................ ON
-- ENABLE_SPELLCHECK ON
-- ENABLE_TOUCH_EVENTS ..................... ON
-- ENABLE_VIDEO ON
-- ENABLE_WAYLAND_TARGET ................... OFF
-- ENABLE_WEB_AUDIO ON
-- ENABLE_X11_TARGET ....................... ON
-- USE_LIBHYPHEN ON
-- USE_LIBNOTIFY ........................... ON
-- USE_SYSTEM_MALLOC OFF
There is in fact no need to check if we're running under Wayland at those points in webkitWebViewBaseRealize/Unrealize, as they're unreachable if Wayland support is enabled. Nothing to change here, I think.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>