<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] Arrow function syntax. Emit loading&putting this/super only if they are used in arrow function"
href="https://bugs.webkit.org/show_bug.cgi?id=153981">bug 153981</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #272424 Flags</td>
<td>
</td>
<td>review?, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] Arrow function syntax. Emit loading&putting this/super only if they are used in arrow function"
href="https://bugs.webkit.org/show_bug.cgi?id=153981#c49">Comment # 49</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] Arrow function syntax. Emit loading&putting this/super only if they are used in arrow function"
href="https://bugs.webkit.org/show_bug.cgi?id=153981">bug 153981</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=272424&action=diff" name="attach_272424" title="Patch">attachment 272424</a> <a href="attachment.cgi?id=272424&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=272424&action=review">https://bugs.webkit.org/attachment.cgi?id=272424&action=review</a>
<span class="quote">>>>>> Source/JavaScriptCore/parser/Parser.cpp:3883
>>>>> + if (currentFunctionScope()->isArrowFunction()) {
>>>>
>>>> I don't understand this code. Why does this happen unconditionally?
>>>> Shouldn't it depend on if "baseIsSuper == true"?
>>>> Also, does this miss the case where you just have "super" without
>>>> a property access or function call afterward?
>>>> I.e:
>>>> ()=>super;
>>>
>>> I don't understand this code. Why does this happen unconditionally?
>>> Shouldn't it depend on if "baseIsSuper == true"?
>>> Also, does this miss the case where you just have "super" without
>>> a property access or function call afterward?
>>> I.e:
>>> ()=>super;
>>
>> I don't understand this code. Why does this happen unconditionally?
>> Shouldn't it depend on if "baseIsSuper == true"?
>> Also, does this miss the case where you just have "super" without
>> a property access or function call afterward?
>> I.e:
>> ()=>super;
>
> I don't understand this code. Why does this happen unconditionally?
> Shouldn't it depend on if "baseIsSuper == true"?
> Also, does this miss the case where you just have "super" without
> a property access or function call afterward?
> I.e:
> ()=>super;</span >
My idea was to check hasDirectSuper & needsSuperBinding that is set when baseIsSuper == true by (setNeedsSuperBinding & setHasDirectSuper), but I see you point, that my current solution is not optimal, it is my fault. I'll rewrite.
In general '()=>super;' should return syntax error: 'Cannot reference super', and it do.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>