<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Opening the inspector in a window causes a crash."
href="https://bugs.webkit.org/show_bug.cgi?id=154444#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Opening the inspector in a window causes a crash."
href="https://bugs.webkit.org/show_bug.cgi?id=154444">bug 154444</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154444#c6">comment #6</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=154444#c5">comment #5</a>)
> > (In reply to <a href="show_bug.cgi?id=154444#c4">comment #4</a>)
> > > (In reply to <a href="show_bug.cgi?id=154444#c3">comment #3</a>)
> > > > Created <span class=""><a href="attachment.cgi?id=272106&action=diff" name="attach_272106" title="Patch">attachment 272106</a> <a href="attachment.cgi?id=272106&action=edit" title="Patch">[details]</a></span>
> > > > Patch
> > > >
> > > > The threaded compositor doesn't handle the case of destroying the native
> > > > surface handle and keeps using the GL context for the destroyed native
> > > > surface. I think this patch also fixes <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][Threaded Compositor] X errors when closing the browser"
href="show_bug.cgi?id=154071">bug #154071</a>, since now when the web
> > > > view is destroyed and unrealize method destroys the surface the threaded
> > > > compositor correctly handles this case.
> > >
> > > Thanks for this patch! I am also working on this though, you are faster than
> > > me. =) At glance, your apporach looks pretty different from mine. I don't
> > > have time to look into the detail now. I believe yoon will review the patch.
> > > ;)
> >
> > What approach were you following? It could be better than mine.
>
> My idea is to destroy only the compositing thread and recreate it without
> touching others like glContext and CoordinatedGraphicsScene, I have a rough
> patch doing that, but it will take some more time until being ready to
> share. Let me share it with you when it is ready.
> BTW, I am still seeing a crash even after applying your patch. Try to
> repeatedly open/close the inspector repeatedly by ctrl + shift + i or
> open/close it in a new window over again.</span >
I'm unable to make it crash with my patch applied.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>