<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for playbackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=154742">bug 154742</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #272362 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for playbackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=154742#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for playbackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=154742">bug 154742</a>
from <span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=272362&action=diff" name="attach_272362" title="Patch">attachment 272362</a> <a href="attachment.cgi?id=272362&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=272362&action=review">https://bugs.webkit.org/attachment.cgi?id=272362&action=review</a>
<span class="quote">> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:213
> + double start = timeRanges.start(i, exceptionCode);
> + double end = timeRanges.end(i, exceptionCode);
> +
> + CMTimeRange range = CMTimeRangeMake(CMTimeMakeWithSeconds(start, 1000), CMTimeMakeWithSeconds(end-start, 1000));
> + [seekableRanges addObject:[NSValue valueWithCMTimeRange:range]];</span >
You can use timeRanges.ranges() to get a PlatformTimeRanges. This object's start() and end() methods don't take an exception code, and they return MediaTime objects. So this would become:
const PlatformTimeRanges& ranges = timeRanges.ranges();
CMTimeRange range = CMTimeRangeMake(toCMTime(ranges.start(i)), toCMTime(ranges.end(i)));
<span class="quote">> Source/WebCore/platform/spi/mac/AVFoundationSPI.h:35
> +#import <AVFoundation/AVTime.h></span >
AVTime.h should be available in the SDK.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>