<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484">bug 154484</a>
from <span class="vcard"><a class="email" href="mailto:olivier.blin@softathome.com" title="Olivier Blin <olivier.blin@softathome.com>"> <span class="fn">Olivier Blin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154484#c10">comment #10</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271958&action=diff" name="attach_271958" title="Patch">attachment 271958</a> <a href="attachment.cgi?id=271958&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271958&action=review">https://bugs.webkit.org/attachment.cgi?id=271958&action=review</a>
>
> >>> Source/WebCore/platform/text/LocaleICU.h:86
> >>> +#endif
> >>
> >> Would be better to initialize these data members here. Then we would not need the conditional initialization lines in the constructor.
> >
> > But the UNumberFormat type would be unknown, and we would have to forward-declare it to allow using a pointer on it.
> >
> > Is it worth doing this?
> > If so, I can resend a patch.
>
> We can initialize to null without any other changes:
>
> #if !UCONFIG_NO_FORMATTING
> UNumberFormat* m_numberFormat { nullptr };
> bool m_didCreateDecimalFormat { false };
> #endif
>
> I don’t know what you mean by “we would have to forward-declare it”.</span >
Ok, looks good this way.
Sorry, I misinterpreted your initial comment.
<span class="quote">> And yes, I do think it’s worth doing this so we can remove the four lines of
> code in the constructor that conditionally initialize these data members.</span >
Then, I should do the same for the other LocalICU fields that have been made conditional in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES"
href="show_bug.cgi?id=154483">bug 154483</a>, right?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>