<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361">bug 153361</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153361#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=272234&action=diff" name="attach_272234" title="Patch">attachment 272234</a> <a href="attachment.cgi?id=272234&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=272234&action=review">https://bugs.webkit.org/attachment.cgi?id=272234&action=review</a>
>
> > Source/WebCore/accessibility/AXObjectCache.cpp:121
> > + if (AXObjectCache::accessibilityEnabled() && selection.isRange())
>
> if ax is not enabled it seems like we should not do anything</span >
Meaning we shouldn't initialize m_replacedText?
<span class="quote">>
> > Source/WebCore/accessibility/AXObjectCache.cpp:124
> > + m_replacedText = String();
>
> this seems unnecessary. i think this is what m_replacedText will be
> initialized to regardless</span >
I'll have to check.
<span class="quote">>
> > Source/WebCore/editing/CompositeEditCommand.cpp:637
> > + default:
>
> feel like we should ASSERT_NOT_REACHED for default: and expect someone will
> pass in Cut or Delete</span >
Will do.
<span class="quote">>
> > Source/WebCore/editing/DictationCommand.cpp:113
> > + notifyAccessibilityForTextChange(AXTextEditTypeDictation, m_textToInsert)
>
> check Internals.cpp for whether dictation has some stubs to direct data
> through</span >
Will do.
<span class="quote">>
> > Source/WebCore/editing/Editor.cpp:543
> > + applyCommand(cmd);
>
> this change seems unneeded</span >
I need it for cmd->replacedText()
<span class="quote">>
> > Source/WebCore/editing/Editor.cpp:557
> > + if (AXObjectCache::accessibilityEnabled() && editingAction == EditActionPaste)
>
> seems like we should cleanup memory when not being used</span >
I'm inclined to reclaim the cmd->replacedText() memory after this if regardless since it's not used again (although it might be in the incomplete undo logic.
<span class="quote">>
> > Source/WebCore/editing/Editor.cpp:1283
> > + cache->postTextStateChangeNotification(node, AXTextEditTypeCut, text, start);
>
> do we need to check for node == nil here? can postTextState changes handle
> the nil node case instead?</span >
In the nil node case postTextStateChangeNotification ends up using the web area for the notification (on OS X) so I could drop that check.
<span class="quote">>
> > Source/WebCore/editing/InsertTextCommand.cpp:143
> > + // FIXME: Need to capture the deleted selection and post replacement notification after insertion
>
> any fixme: should probably have a webkit bug tied to it</span >
That's out of date. I'll remove it.
<span class="quote">>
> > LayoutTests/accessibility/mac/value-change-userinfo.html:195
> > +// execExtendSelectionRightByCharacterCommand();
>
> should this be deleted?</span >
Yes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>