<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484">bug 154484</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271958 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)"
href="https://bugs.webkit.org/show_bug.cgi?id=154484">bug 154484</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271958&action=diff" name="attach_271958" title="Patch">attachment 271958</a> <a href="attachment.cgi?id=271958&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271958&action=review">https://bugs.webkit.org/attachment.cgi?id=271958&action=review</a>
<span class="quote">> Source/WebCore/platform/text/LocaleICU.h:86
> +#if !UCONFIG_NO_FORMATTING
> UNumberFormat* m_numberFormat;
> bool m_didCreateDecimalFormat;
> +#endif</span >
Would be better to initialize these data members here. Then we would not need the conditional initialization lines in the constructor.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>