<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add MediaEndpoint interface (WebRTC backend abstraction)"
href="https://bugs.webkit.org/show_bug.cgi?id=150165">bug 150165</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271795 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add MediaEndpoint interface (WebRTC backend abstraction)"
href="https://bugs.webkit.org/show_bug.cgi?id=150165#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add MediaEndpoint interface (WebRTC backend abstraction)"
href="https://bugs.webkit.org/show_bug.cgi?id=150165">bug 150165</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271795&action=diff" name="attach_271795" title="Updated patch">attachment 271795</a> <a href="attachment.cgi?id=271795&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271795&action=review">https://bugs.webkit.org/attachment.cgi?id=271795&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:11
> + configure the WebRTC backend how to send and receive. It also abstracts</span >
Nit: "configure the WebRTC backend how to send and receive" -> something like "configure how the the WebRTC backend sends and receives"
<span class="quote">> Source/WebCore/platform/mediastream/IceCandidate.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Nit: you might want to update this.
<span class="quote">> Source/WebCore/platform/mediastream/IceCandidate.h:103
> + : m_componentId(0)
> + , m_priority(0)
> + , m_port(0)
> + , m_relatedPort(0)</span >
These should be initialized in the class definition:
unsigned m_componentId { 0 };
int m_priority { 0 };
etc.
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:40
> + return nullptr;</span >
Should this ASSERT?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpoint.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpointConfiguration.cpp:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpointConfiguration.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:72
> + : m_sessionId(cryptographicallyRandomNumber()) // FIXME: should be 64 bits</span >
Can you initialize this by bit-shifting two random 32 bit numbers?
<span class="quote">> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:73
> + , m_sessionVersion(0)</span >
This should be initialized in the class definition.
<span class="quote">> Source/WebCore/platform/mediastream/MediaPayload.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/MediaPayload.h:102
> + : m_type(0)
> + , m_clockRate(0)
> + , m_channels(0)
> + , m_ccmfir(false)
> + , m_nackpli(false)
> + , m_nack(false)</span >
These should be initialized in the class definition.
<span class="quote">> Source/WebCore/platform/mediastream/PeerMediaDescription.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.</span >
Update?
<span class="quote">> Source/WebCore/platform/mediastream/PeerMediaDescription.h:154
> + : m_port(0)
> + , m_rtcpMux(false)
> + , m_rtcpPort(0)
> + , m_source(nullptr)</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>