<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486">bug 154486</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271840 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486">bug 154486</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271840&action=diff" name="attach_271840" title="Patch">attachment 271840</a> <a href="attachment.cgi?id=271840&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271840&action=review">https://bugs.webkit.org/attachment.cgi?id=271840&action=review</a>
<span class="quote">>>> Source/JavaScriptCore/runtime/IntlCollator.cpp:329
>>> + auto collator = std::unique_ptr<UCollator, UCollatorDeleter>(ucol_open(m_locale.utf8().data(), &status));
>>
>> Use std::make_unique from StdLibExtras.h
>
> I don't think that works, because ucol_open is not a C++ constructor.</span >
That’s right. Can’t use make_unique here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>