<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC shell] Don't put empty arguments array to VM."
href="https://bugs.webkit.org/show_bug.cgi?id=154516#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC shell] Don't put empty arguments array to VM."
href="https://bugs.webkit.org/show_bug.cgi?id=154516">bug 154516</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154516#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271884&action=diff" name="attach_271884" title="Patch">attachment 271884</a> <a href="attachment.cgi?id=271884&action=edit" title="Patch">[details]</a></span>
> Patch
>
> I don't think the current approach is good because we would like to assume
> that there is an empty `arguments` if the CLI does not pass any arguments.
>
> How about the following idea?
> 1. adding an Option (see runtime/Options.h), that controls exposing the
> `arguments`. Now, we can control this behavior with the environment variable
> JSC_XXX (If you add an option XXX, we can switch it with the environment
> variable JSC_XXX)
> 3. adding a ruby function notExposeArguments() in run-jsc-stress-tests,
> which defines JSC_XXX environment variable before executing the command.
> (Let's define addEnvVar(X, Y). And calling it as def notExposeArguments
> addEnvVar("JSC_XXX", "true"))
> 4. defining the annotation "//@ notExposeArguments" instead of "//@ skip"</span >
Problem is that I use run-layout-jsc, which does not support annotations, and my initial motivation for this change was to allow this test to pass without @ skip annotation.
Though run-layout-jsc may unconditionally use this mode.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>