<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Emit loading&putting this/super only if they are used in arrow function"
href="https://bugs.webkit.org/show_bug.cgi?id=153981#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Emit loading&putting this/super only if they are used in arrow function"
href="https://bugs.webkit.org/show_bug.cgi?id=153981">bug 153981</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=271854&action=diff" name="attach_271854" title="Patch">attachment 271854</a> <a href="attachment.cgi?id=271854&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271854&action=review">https://bugs.webkit.org/attachment.cgi?id=271854&action=review</a>
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4050
>> + return m_codeBlock->doAnyInnerArrowFunctionsUseNewTarget() || m_codeBlock->doAnyInnerArrowFunctionsUseSuperCall() || m_codeBlock->doAnyInnerArrowFunctionsUseEval();
>
> I was wrong about this. new.target is prohibited inside eval. Sorry for stating the wrong thing in my previous review.</span >
Fixed
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4055
>> + return m_codeBlock->doAnyInnerArrowFunctionsUseSuperCall() || m_codeBlock->doAnyInnerArrowFunctionsUseSuperProperty() || m_codeBlock->doAnyInnerArrowFunctionsUseEval() || m_codeBlock->usesEval();
>
> Also, 'super' isn't allowed inside an eval. It's a SyntaxError.</span >
I fixed. However we have issue where will fix this SyntaxError :-)
<span class="quote">>> Source/JavaScriptCore/parser/Parser.h:473
>> + setInnerArrowFunctionUseArgumetns();
>
> An alternative to doing this at every useVariable(.) call
> is to just do it once when popScope happens.</span >
OK. Refactored.
<span class="quote">>> Source/JavaScriptCore/parser/Parser.h:953
>> + // We do not up arrow function features for ordinary function
>
> comment not needed.</span >
Removed</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>