<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486">bug 154486</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154486#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271840&action=diff" name="attach_271840" title="Patch">attachment 271840</a> <a href="attachment.cgi?id=271840&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271840&action=review">https://bugs.webkit.org/attachment.cgi?id=271840&action=review</a>
>
> > Source/JavaScriptCore/runtime/IntlCollator.cpp:329
> > + auto collator = std::unique_ptr<UCollator, UCollatorDeleter>(ucol_open(m_locale.utf8().data(), &status));
>
> Use std::make_unique from StdLibExtras.h</span >
I don't think that works, because ucol_open is not a C++ constructor.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>