<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro."
href="https://bugs.webkit.org/show_bug.cgi?id=154450#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro."
href="https://bugs.webkit.org/show_bug.cgi?id=154450">bug 154450</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154450#c6">comment #6</a>)
<span class="quote">> I think the value of moving this duplicate code to a macro probably
> outweighs the value of being explicit, so I'm OK with this.</span >
It seems to me that there is established set of "standard" variables for each WebKit target that configure it. So this patch would not only reduce code size, but would also help to make target behavior more consistent in future. I'm planning to submit similar patches for binaries and non-framework libraries.
Also, it would simplify addition of new configurable properties, e.g. in Qt port we would like to override precompiled header files via variables like WebCore_PRECOMPILED_HEADER.
I want to give
<span class="quote">> Alex and Martin a chance to chime in, though.
>
> I'm not sure about getting rid of WebKit2_DERIVED_SOURCES, because I think
> we might want to set different CPPFLAGS there to silence some warnings we
> currently have. And Alex has a patch introducing WebCore_DERIVED_SOURCES in
> <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix Ninja build on Mac"
href="show_bug.cgi?id=151399">bug #151399</a>.</span >
Note that he adds WebCore_DERIVEDSOURCES, not WebCore_DERIVED_SOURCES, breaking "convention" of WebKit2. If we really need to use different flags on derived sources, I will add ${${_target}_DERIVED_SOURCES} to source list of target.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>