<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test to check scroll animator events after a history navigation"
href="https://bugs.webkit.org/show_bug.cgi?id=154333#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test to check scroll animator events after a history navigation"
href="https://bugs.webkit.org/show_bug.cgi?id=154333">bug 154333</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154333#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271541&action=diff" name="attach_271541" title="Patch">attachment 271541</a> <a href="attachment.cgi?id=271541&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271541&action=review">https://bugs.webkit.org/attachment.cgi?id=271541&action=review</a>
>
> Looks good, except for the WK1 test failure that needs fixed.</span >
We just need to skip this test in wk1, I don't see that a reason to reject the patch.
<span class="quote">> > LayoutTests/fast/scrolling/scroll-animator-events-after-history-navigation.html:31
> > + delete sessionStorage.didNavigate;
>
> Why do you need to do this? The test is about to end!</span >
To clean up the session storage so that it won't affect other tests that could use also didNavigate. It's quite common to do this in layout tests.
<span class="quote">> > LayoutTests/fast/scrolling/scroll-animator-events-after-history-navigation.html:37
> > + sessionStorage.didNavigate = true;
>
> This is needed... why, so that the page enters the page cache?</span >
No, this has nothing to do with the page cache. Please, if you have questions about the patch or you didn't understand a part of it, ask any questions before deciding to reject the patch. When a test does a navigation or reload and you want to do different things depending on every navigation you need to store some state somewhere that is alive during navigation, and we normally use the session storage for that. In this case, when the test is loaded the first time we want to navigate to another page that will navigate back. When the page is loaded the second time, we just want to finish the test. The way the test know if it's the first navigation or not is checking the sessionStorage.didNavigate value.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>