<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to Intl code"
href="https://bugs.webkit.org/show_bug.cgi?id=154486">bug 154486</a>
from <span class="vcard"><a class="email" href="mailto:thetalecrafter@gmail.com" title="Andy VanWagoner <thetalecrafter@gmail.com>"> <span class="fn">Andy VanWagoner</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271835&action=diff" name="attach_271835" title="Patch">attachment 271835</a> <a href="attachment.cgi?id=271835&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271835&action=review">https://bugs.webkit.org/attachment.cgi?id=271835&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:674
> + m_dateFormat = std::unique_ptr<UDateFormat, UDateFormatDeleter>(udat_open(UDAT_IGNORE, UDAT_IGNORE, m_locale.utf8().data(), timeZoneView.upconvertedCharacters(), timeZoneView.length(), pattern.upconvertedCharacters(), pattern.length(), &status));</span >
Since ICU headers were updated to v52, UDAT_PATTERN is preferred over UDAT_IGNORE. Mind changing that while you are in here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>