<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position"
href="https://bugs.webkit.org/show_bug.cgi?id=115363">bug 115363</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270996 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position"
href="https://bugs.webkit.org/show_bug.cgi?id=115363#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position"
href="https://bugs.webkit.org/show_bug.cgi?id=115363">bug 115363</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270996&action=diff" name="attach_270996" title="Patch">attachment 270996</a> <a href="attachment.cgi?id=270996&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270996&action=review">https://bugs.webkit.org/attachment.cgi?id=270996&action=review</a>
Looks great
<span class="quote">> Source/WebCore/ChangeLog:8
> + Allow RenderTheme to decide the behavior of a button press event,</span >
RenderTheme -> ScrollbarTheme
<span class="quote">> Source/WebCore/ChangeLog:15
> + (WebCore::Scrollbar::mouseDown): Ask RenderTheme to handle the</span >
Ditto.
<span class="quote">> Source/WebCore/platform/Scrollbar.cpp:396
> + if (action == ScrollbarButtonPressAction::None)</span >
Eh... on the one hand, it's probably the best solution.
On the other hand, it's not great that policy is decided by a class called "theme." Did you consider having Scrollbar::platformHandleMousePressEvent and adding new files for each port just to implement that; it's a bit more work, but this is platform after all.
On the other other hand, shouldCenterOnThumb is already there, and maybe the logic is tied so closely to the theme it's just the best place. So whatevs.
<span class="quote">> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:449
> + break;</span >
Fix this unreachable break
<span class="quote">> Source/WebCore/platform/win/ScrollbarThemeWin.cpp:209
> + break;</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>