<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:akling@apple.com" title="Andreas Kling <akling@apple.com>"> <span class="fn">Andreas Kling</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor id mutation style invalidation code into a class"
href="https://bugs.webkit.org/show_bug.cgi?id=154287">bug 154287</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271427 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor id mutation style invalidation code into a class"
href="https://bugs.webkit.org/show_bug.cgi?id=154287#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor id mutation style invalidation code into a class"
href="https://bugs.webkit.org/show_bug.cgi?id=154287">bug 154287</a>
from <span class="vcard"><a class="email" href="mailto:akling@apple.com" title="Andreas Kling <akling@apple.com>"> <span class="fn">Andreas Kling</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271427&action=diff" name="attach_271427" title="patch">attachment 271427</a> <a href="attachment.cgi?id=271427&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271427&action=review">https://bugs.webkit.org/attachment.cgi?id=271427&action=review</a>
r=me
<span class="quote">> Source/WebCore/ChangeLog:12
> + However dynamic id changes are not common enought (nor recommended) to pay the memory cost of
> + the required data structures.</span >
Strongly agree with this.
Also s/enought/enough/
<span class="quote">> Source/WebCore/WebCore.xcodeproj/project.pbxproj:10555
> - 83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSXMLHttpRequestEventTarget.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> - 83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSXMLHttpRequestEventTarget.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
> + 83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> + 83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
> 83E359A01BB1031D002CEB98 /* JSHTMLTimeElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLTimeElement.h; sourceTree = "<group>"; };</span >
I don't know what these are about.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>