<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Number Format Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=147605#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Number Format Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=147605">bug 147605</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147605#c10">comment #10</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=271263&action=diff" name="attach_271263" title="Patch">attachment 271263</a> <a href="attachment.cgi?id=271263&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271263&action=review">https://bugs.webkit.org/attachment.cgi?id=271263&action=review</a>
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:70
> > +IntlNumberFormat::~IntlNumberFormat()
> > +{
> > + if (m_numberFormat)
> > + unum_close(m_numberFormat);
> > +}
>
> I would have slightly preferred that we use std::unique_ptr instead.
>
> struct UNumberFormatDeleter {
> void operator()(UNumberFormat* numberFormat) const
> {
> if (numberFormat)
> unum_close(numberFormat);
> }
> };
>
> std::unique_ptr<UNumberFormat, UNumberFormatDeleter> m_numberFormat;
>
> If we did that, we would not need to define ~IntlNumberFormat() and other
> code would be a bit simpler as well.
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:401
> > + UNumberFormat* numberFormat = unum_open(style, nullptr, 0, m_locale.utf8().data(), nullptr, &status);
>
> If we used std::unique_ptr this would be:
>
> auto numberFormat = std::unique_ptr<UNumberFormat,
> UNumberFormatDeleter>(unum_open(style, nullptr, 0, m_locale.utf8().data(),
> nullptr, &status));
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:406
> > + unum_setTextAttribute(numberFormat, UNUM_CURRENCY_CODE, StringView(m_currency).upconvertedCharacters(), 3, &status);
>
> If we used std::unique_ptr, these lines would need to use get().
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:419
> > + unum_close(numberFormat);
>
> We would not need this if we used std::unique_ptr.
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:423
> > + m_numberFormat = numberFormat;
>
> This line would need to be:
>
> m_numberFormat = WTFMove(numberFormat);</span >
Done. Thanks. I will update other Intl classes to std::unique_ptr in a separate patch.
<span class="quote">> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:436
> > + if (bitwise_cast<uint64_t>(number) == bitwise_cast<uint64_t>(-0.0))
> > + number = 0.0;
>
> How is the bitwise_cast code better than:
>
> // Map negative zero to positive zero.
> if (!number)
> number = 0;
>
> I don’t think it is.</span >
Fixed.
<span class="quote">> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:447
> > + return state.vm().throwException(&state, createError(&state, ASCIILiteral("Failed to format a number.")));
>
> Where is the test coverage for this? When can this fail?</span >
The ICU spec doesn't say what can cause unum_formatUFormattable to fail, and I can't find a case that makes it fail. I put the check in there just in case.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>