<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230#c35">Comment # 35</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230">bug 153230</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153230#c34">comment #34</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=153230#c33">comment #33</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=270743&action=diff" name="attach_270743" title="Try to fix mac builds">attachment 270743</a> <a href="attachment.cgi?id=270743&action=edit" title="Try to fix mac builds">[details]</a></span>
> > Try to fix mac builds
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=270743&action=review">https://bugs.webkit.org/attachment.cgi?id=270743&action=review</a>
> >
> > > Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:52
> > > + bool restoredFromSession;
> >
> > A thought just occurred to me. Don't we need to reset this flag at some
> > point? Otherwise, it seems like we would *never* again use the back/forward
> > cache policy to these history items (unless the HistoryItems get regenerated
> > somehow?).
>
> That was my first idea, but it was not easy to decide when to reset it, and
> I realized that it was not actually needed, because after the first time,
> the resource will always hit the page cache or the memory cache if the page
> cache is disabled, but we won't reach the disk cache again.</span >
It *may* use the PageCache or the memory cache but there is definitely no guarantee of this happening AFAIK. Relying on this seems wrong.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>