<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235">bug 154235</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235">bug 154235</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154235#c8">comment #8</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=154235#c7">comment #7</a>)
> >
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:896
> > > + if (!equalIgnoringASCIICase(keySystem, "org.w3.clearkey"))
> > > + return MediaPlayer::KeySystemNotSupported;
> >
> > Instead of duplication this check here, we could call supportsKeySystem
> > instead, or move this check to a helper function and use it from both places.
> >
>
> I'm not sure it's worth.</span >
If the condition changes for whatever reason you will have to change it everywhere.
<span class="quote">> >
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:931
> > > + if (parameters.keySystem.isNull() || parameters.keySystem.isEmpty())
> >
> > parameters.keySystem.isEmpty() returns true if it's null
> >
>
> So you mean testing only isNull() is enough?</span >
No, isEmpty is enough.
<span class="quote">> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:57
> > > +void registerWebKitGStreamerElements();
> > > +
> >
> > Why does this need to be here? Can't this be a static function?
> >
>
> It will need to be called from the future MediaPlayerPrivateGStreamerMSE.</span >
Ah, ok, I think changing that in the future patch makes this easiert o understand.
<span class="quote">> >
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:128
> > > + virtual void dispatchDecryptionKey(GstBuffer*);
> >
> > Why is this virtual and public?
> >
>
> The MediaPlayerPrivateGStreamerMSE player will need to override it. But
> maybe it can be private though, I'll check.</span >
Same here, I guess it could be protected.
<span class="quote">> I'll process the remain comments later on :) Thanks!</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>