<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Consolidate building of GStreamer and OpenWebRTC code."
href="https://bugs.webkit.org/show_bug.cgi?id=154116#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake] Consolidate building of GStreamer and OpenWebRTC code."
href="https://bugs.webkit.org/show_bug.cgi?id=154116">bug 154116</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271071&action=diff" name="attach_271071" title="Patch">attachment 271071</a> <a href="attachment.cgi?id=271071&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271071&action=review">https://bugs.webkit.org/attachment.cgi?id=271071&action=review</a>
Seems like this is indeed the best place for OpenWebRTC, then.
<span class="quote">> Source/WebCore/platform/GStreamer.cmake:5
> +list(APPEND WebCore_SOURCES</span >
I think you can conditionally append these files to WebCore_SOURCES in the ENABLE_VIDEO OR ENABLE_WEB_AUDIO condition below; then in a follow-up we could remove the preprocessor guards from the files.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>