<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056">bug 149056</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #271148 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Spellchecker rejects word when adding a period character if there is no trailing space before the next word"
href="https://bugs.webkit.org/show_bug.cgi?id=149056">bug 149056</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271148&action=diff" name="attach_271148" title="Check every parts of words containing periods or colons.">attachment 271148</a> <a href="attachment.cgi?id=271148&action=edit" title="Check every parts of words containing periods or colons.">[details]</a></span>
Check every parts of words containing periods or colons.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271148&action=review">https://bugs.webkit.org/attachment.cgi?id=271148&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).</span >
I think this change deserves a test.
<span class="quote">> Source/WebCore/ChangeLog:17
> + - or Swedish and Finnish words containing a colon.</span >
I think we need to understand why this is a problem for Enchant and not for the Mac port. If it is a problem for the Mac port, we likely need to do this fix at a higher level. We should compare the behavior of the GTK+ port to Safari.
<span class="quote">> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:-102
> int start = textBreakFirst(iter);
> for (int end = textBreakNext(iter); end != TextBreakDone; end = textBreakNext(iter)) {
> if (isWordTextBreak(iter)) {
> - checkSpellingOfWord(utf8String, start, end, misspellingLocation, misspellingLength);</span >
Why isn't wordBreakIterator breaking on the punctuation already? I think that understanding the context of the problem is important to reviewing the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>